[Doc] add an example of single subject rois; reduce example time #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g them to share derivatives not dependent on tractography, such as mapping, csd, etc
36000
force-pushed
the
single_subject_example
branch
from
43524f6
to
7cf4ddd
Compare
|
@arokem this is ready for review/merge |
arokem
requested changes
Aug 26, 2023
There was a problem hiding this comment.
This is mostly great. I think that the example text itself could be slightly improved to be a bit more explanatory. Also, I believe that this currently wouldn't automatically be run, because the file name doesn't start with "plot_". Was that your intention? Or should we run this and produce the outputs?
examples/tutorial_examples/use_subject_space_rois_from_freesurfer.py
Outdated
Show resolved
Hide resolved
examples/tutorial_examples/use_subject_space_rois_from_freesurfer.py
Outdated
Show resolved
Hide resolved
examples/tutorial_examples/use_subject_space_rois_from_freesurfer.py
Outdated
Show resolved
Hide resolved
examples/tutorial_examples/use_subject_space_rois_from_freesurfer.py
Outdated
Show resolved
Hide resolved
|
I don't think this needs to be run. I am going to merge this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduce example time by allowing them to share derivatives not dependent on tractography, such as mapping, csd, etc